Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chrome.extensions.vm #1139

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Add chrome.extensions.vm #1139

merged 1 commit into from
Nov 15, 2024

Conversation

d35ha
Copy link
Member

@d35ha d35ha commented Sep 30, 2024

Closes #846.

@d35ha d35ha force-pushed the Chrome-Extensions branch 6 times, most recently from 1a889b1 to be7a3d2 Compare September 30, 2024 11:51
@Ana06 Ana06 added 🆕 package New package request/idea/PR 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Sep 30, 2024
@d35ha d35ha force-pushed the Chrome-Extensions branch from be7a3d2 to b0df89f Compare October 1, 2024 10:20
@Ana06
Copy link
Member

Ana06 commented Oct 1, 2024

It seems this PR is being affected by #1138. We need to fix #1138 before being able to merge this PR. The fix is not difficult as I explained in #1138 (comment). @d35ha would you like to fix #1138 (ideally as a separate PR)? If so, please assign the issue to you 😉

@d35ha d35ha force-pushed the Chrome-Extensions branch 2 times, most recently from 074a586 to 36485b4 Compare October 2, 2024 08:23
@d35ha
Copy link
Member Author

d35ha commented Oct 2, 2024 •
edited
Loading

It seems this PR is being affected by #1138. We need to fix #1138 before being able to merge this PR. The fix is not difficult as I explained in #1138 (comment). @d35ha would you like to fix #1138 (ideally as a separate PR)? If so, please assign the issue to you 😉

It seems it's working now, anyway fixed at #1146.

@d35ha d35ha force-pushed the Chrome-Extensions branch from 36485b4 to 1985d3e Compare October 2, 2024 13:05
@d35ha d35ha force-pushed the Chrome-Extensions branch from 1985d3e to f929ecb Compare October 3, 2024 08:25
@d35ha d35ha requested a review from Ana06 October 4, 2024 08:25
@emtuls emtuls self-requested a review October 7, 2024 03:22
Ana06
Ana06 requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it locally and it seems to work fine 🚀 I have some minor changes requests, could you address those @d35ha so that we can merge this PR? 😉

packages/chrome.extensions.vm/tools/chocolateyuninstall.ps1 Show resolved Hide resolved
packages/chrome.extensions.vm/chrome.extensions.vm.nuspec Outdated Show resolved Hide resolved
packages/chrome.extensions.vm/tools/chocolateyinstall.ps1 Outdated Show resolved Hide resolved
packages/chrome.extensions.vm/tools/chocolateyinstall.ps1 Outdated Show resolved Hide resolved
@d35ha d35ha force-pushed the Chrome-Extensions branch 2 times, most recently from ab50fed to 804247e Compare November 15, 2024 12:11
@d35ha d35ha force-pushed the Chrome-Extensions branch from 804247e to 061532b Compare November 15, 2024 12:14
Ana06
Ana06 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback @d35ha! Let's merge it! 🎉

@Ana06 Ana06 merged commit 914d0e1 into mandiant:main Nov 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emtuls emtuls emtuls approved these changes

@Ana06 Ana06 Ana06 approved these changes

Assignees

@d35ha d35ha

Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 🆕 package New package request/idea/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package proposal: chrome.extensions.vm
3 participants
@d35ha @Ana06 @emtuls